opt(annotation): support concurrently register and find Annotation
#100
+27
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnotationAnnotation
jayantxie
reviewed
May 6, 2025
| if m == nil { | ||
| m = make(map[AnnoScope]Annotation) | ||
| annotations[key] = m | ||
| m = new(sync.Map) |
There was a problem hiding this comment.
这个没办法，即使并发重复key注册上了，使用时候可能还是有bug。除非整个idl解析流程都加锁（串行）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: support concurrently register and find
Annotationzh(optional): 支持并发注册和获取
Annotation(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: