10000 Use more condensed output by mwildehahn · Pull Request #182 · cloudtools/stacker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use more condensed output #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 11, 2016
Merged

Use more condensed output #182

merged 7 commits into from
Aug 11, 2016

Conversation

mwildehahn
Copy link
Contributor
@mwildehahn mwildehahn commented Aug 2, 2016 •
edited
Loading

This also adds a --replacements-only flag which will only prompt for approval when the resource requires replacement

@mwildehahn mwildehahn changed the title By default, only ask for approval when a change requires a replacement Use more condensed output Aug 2, 2016
@mwildehahn
Copy link
Contributor Author

Default output:

[2016-08-02T16:12:09] mh-empire-dev-empireDaemon changes:
Replacements:
- Modify TaskDefinition (AWS::ECS::TaskDefinition)
Changes:
- Modify Service (AWS::ECS::Service)
Execute the above changes? [y/n/v] v

Output with --replacements-only:

[2016-08-02T16:06:46] mh-empire-dev-empireDaemon replacements:
- Modify TaskDefinition (AWS::ECS::TaskDefinition)
Execute the above changes? [y/n/v] n

phobologic
phobologic reviewed Aug 4, 2016
View reviewed changes
stacker/providers/aws/interactive.py
changeset (List): List of changes

Returns:
List: A list of changes that require replacement, if any.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: List -> list

@phobologic
Copy link
Member

Other than the nits/docstrings, this looks good! 👍

@mwildehahn mwildehahn merged commit 0019fd1 into cloudtools:master Aug 11, 2016
@mwildehahn mwildehahn deleted the change-sets-strict branch August 11, 2016 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwildehahn @phobologic
0