Fix traceback on interactive provider when adding resources #198
Conversation
| @@ -80,7 +80,7 @@ def output_summary(fqn, action, changeset, replacements_only=False): | |||
| changes = [] | |||
| for change in changeset: | |||
| resource = change['ResourceChange'] | |||
| replacement = resource['Replacement'] == 'True' | |||
| replacement = resource.get('Replacement', '') == 'True' | |||
There was a problem hiding this comment.
Only a minor nit: You can just do resource.get('Replacement') == 'True'
.get() will return None by default if the key doesn't exist.
There was a problem hiding this comment.
Right. I got into the habit of making it explicit for clarity, and I thought it would maybe be better to return a string for uniformity, but it's only a matter of preference, and keeping it like the rest of the codebase is best.
There was a problem hiding this comment.
Yeah - I think I prefer just letting it use the usual default, unless there's actually something useful about specifying a new default. If you can update that, I'll pull this in ASAP :) Thanks @danielkza
There was a problem hiding this comment.
@phobologic Done.
|
This looks good - one minor change, and I'll go ahead and merge. Thanks @danielkza ! |
It seems it's possible for resources to omit the 'Replacement' key instead of setting it to false. Handle that case instead of assuming the key is always present.
94afae1 to
4b2e8bf
Compare
|
Thanks! |
It seems it's possible for resources to omit the 'Replacement' key
instead of setting it to false. Handle that case instead of assuming the
key is always present.
Fixes a traceback like the following: