Support "allowed_values" within variable definitions #245
Conversation
| allowed_values = var_def.get('allowed_values') | ||
| valid = validate_allowed_values(allowed_values, value) | ||
| if not valid: | ||
| raise UnallowedValue(var_name, value, allowed_values) |
There was a problem hiding this comment.
Do you think we need a special exception here? Seems like a ValueError, though I guess at the point where we move to all stacker exceptions being from a base exception this might be useful.
There was a problem hiding this comment.
Yea, I was just using the UnallowedValue error to construct the message which probably isn't worth it
| class UnallowedValue(Exception): | ||
| """Exception raised when the value provided to a variable is not allowed. | ||
| """ | ||
| def __init__(self, variable, value, allowed_values, *args, **kwargs): |
There was a problem hiding this comment.
This might be hard to find, since it doesn't list what blueprint it's a part of. I actually am starting to feel like we should be doing more with catching exceptions at the blueprint, plan or stack level to provide more context, rather than needing to pass that context down to each exception in order to figure out where things are breaking.
There was a problem hiding this comment.
Yea, a base exception that includes blueprint and some other data would be useful. I'm going to switch this to a ValueError for now and we can address this with the issue to track better exception handling
No description provided.