8000 Make --stacks flag build dependencies by ejholmes · Pull Request #282 · cloudtools/stacker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make --stacks flag build dependencies #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make --stacks flag build dependencies #282

wants to merge 1 commit into from

Conversation

ejholmes
Copy link
Contributor
@ejholmes ejholmes commented Dec 2, 2016 •
edited
Loading

Closes #186

This allows the --stacks flag to support building the stacks dependencies, so you don't need to do it manually. For example, say you had this configuration:

stacks:
  - name: a
    class_path: stacker.dev.blueprints.Dummy
  - name: b
    class_path: stacker.dev.blueprints.Dummy
    parameters:
      DummyParameter: a::DummyOutput
  - name: c
    class_path: stacker.dev.blueprints.Dummy
    parameters:
      DummyParameter: b::DummyOutput

Previously, if I wanted to build only c, I would have to specify --stacks a --stacks b --stacks c. With this change, you only need to specify --stacks c and stacker will build a and and b implicitly.

This depends on the DAG refactor in #280

@phobologic
Copy link
Member

Looks good - it's a backwards incompatible change, but I don't think it's an unexpected one. One thing - I just merged #278 and I think this will break that, can you merge that in here and make it so this works with destroy as well?

@ejholmes
Copy link
Contributor Author
ejholmes commented Dec 4, 2016

Yep, totally. It makes conceptual sense to do the same for destroying. In the example above, if I want to destroy stack b, then I need to destroy stack c first since it depends on b.

@phobologic phobologic mentioned this pull request Jan 23, 2017
Closed
@ejholmes
Copy link
Contributor Author

See #280 (comment). I'll follow up on this later.

@ejholmes ejholmes closed this Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejholmes @phobologic
0