8000 Remove python-dateutil from setup.py by ejholmes · Pull Request #556 · cloudtools/stacker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove python-dateutil from setup.py #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Remove python-dateutil from setup.py #556

merged 1 commit into from
Mar 14, 2018

Conversation

ejholmes
Copy link
Contributor

Recent versions of botocore lock this to python-dateutil>=2.1,<2.7.0. It may be best for us to just remove the version requirement here and rely on botocore's.

@ejholmes ejholmes requested a review from phobologic March 14, 2018 00:50
@@ -14,7 +14,6 @@
"formic~=0.9b",
"gitpython~=2.0",
"schematics~=2.0.1",
"python-dateutil~=2.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also consider mirroring botocore's version spec, since we do have an explicit dependency on python-dateutil added in #487. Not sure what's best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say keep it in here, set it to >=2.0 or something, and make sure botocore is first in the list of dependencies. That should handle it, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't botocore already first in the list of dependencies here?

@@ -14,7 +14,6 @@
"formic~=0.9b",
"gitpython~=2.0",
"schematics~=2.0.1",
"python-dateutil~=2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say keep it in here, set it to >=2.0 or something, and make sure botocore is first in the list of dependencies. That should handle it, right?

@ejholmes
Copy link
Contributor Author

Gonna merge this for now. If there's a better way to specify this dependency with setup tools, I'll address it before the 1.3 release.

@ejholmes ejholmes merged commit 3562a43 into master Mar 14, 2018
@ejholmes ejholmes deleted the dateutil branch March 14, 2018 02:25
phrohdoh pushed a commit to phrohdoh/stacker that referenced this pull request Dec 18, 2018
Remove python-dateutil from setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0