Always dump the current output/result #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue that was introduced in #467. The original functionality was to always dump the current output to `.json-result`, that way it was easy to build & compare the output. With the current implementation (from #467) we raise an exception if the old results aren't available, but don't create the new results. This is an issue whenever creating a new test.
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 88.72% 88.72%
=======================================
Files 92 92
Lines 5926 5926
=======================================
Hits 5258 5258
Misses 668 668
Continue to review full report at Codecov.
|
I can't see how it would either, and getting more information for debugging is always nice. |
danielkza
approved these changes
Feb 3, 2018
|
Thanks @danielkza ! |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
* Always dump the current output/result This fixes an issue that was introduced in cloudtools#467. The original functionality was to always dump the current output to `.json-result`, that way it was easy to build & compare the output. With the current implementation (from cloudtools#467) we raise an exception if the old results aren't available, but don't create the new results. This is an issue whenever creating a new test. * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This fixes an issue that was introduced in #467. The original
functionality was to always dump the current output to
.json-result,that way it was easy to build & compare the output.
With the current implementation (from #467) we raise an exception if the
old results aren't available, but don't create the new results. This is
an issue whenever creating a new test.
@danielkza can you verify that this doesn't break anything that you were trying to fix in #467? I can't see how it would.