Add back support for Python 2.6 #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of dictionary comprehension in #468 caused support for Python 2.6 to be dropped. This change converts these comprehensions to use simple iteration.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of dictionary comprehension in #468 caused support for Python
2.6 to be dropped. This change converts these comprehensions to use
simple iteration.
See b8a6dae for a prior example of dictionary comprehensions breaking support. This fix was modeled after that commit. As per that commit the test suite does not run in Python 2.6, however I have tested that
pycodestyle .andpyflakes .both pass when running using python2.6.6 and the unit tests pass when using 2.7.11.Potentially Travis could be configured to run
pycodestyleandpyflakesunder python 2.6 to help with the "best effort" support so even if the unit tests can't run it'll help spot compilation errors but that's a discussion for another day.(Oh I'm using python2.6 rather than upgrading because I'm still stuck on CentOS 6 for some things)