Set EC2 BlockDeviceMapping NoDevice property to type dict #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markpeek
reviewed
Oct 23, 2017
There was a problem hiding this comment.
My apologies with the regression and thanks for jumping on getting a fix out. I made a comment about adding a NO_DEVICE constant to ec2.py to make it more explicit. If you like it, please update and push a new commit. I'll see about merging and releasing an update tonight.
| NoDevice={}), | ||
| ec2.BlockDeviceMapping( | ||
| DeviceName='/dev/sdc', | ||
| NoDevice={}), |
There was a problem hiding this comment.
Would it make sense to add a NO_DEVICE constant in ec2.py?
There was a problem hiding this comment.
I think that's a great idea actually. I'll push it up shortly.
|
|
|
Thanks! |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts EC2->BlockDeviceMapping->NoDevice property to type dict, allowing for a value of
{}as shown in the documentation under theUnmapping an AMI-defined Deviceexample.Also adds an example template of unmapping ephemeral devices on an EC2 instance.
Fixes #865