add TargetGroupInfo to DeploymentGroup #884 #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markpeek
reviewed
Nov 7, 2017
troposphere/codedeploy.py
Outdated
| @@ -4,7 +4,7 @@ | |||
| # See LICENSE file for full license. | |||
|
|
|||
| from . import AWSObject, AWSProperty | |||
| from .validators import boolean, positive_integer | |||
| from .validators import boolean, positive_integer, exactly_one | |||
troposphere/codedeploy.py
Outdated
| class LoadBalancerInfo(AWSProperty): | ||
| props = { | ||
| 'ElbInfoList': ([ElbInfoList], False) | ||
| 'ElbInfoList': ([ElbInfoList], False), | ||
| 'TargetGroupInfoList': ([TargetGroupInfoList], False) |
There was a problem hiding this comment.
I usually always add commas at the end of these lists to make future additions a 1 line change.
There was a problem hiding this comment.
Thank you, I'm always happy to learn best practices.
|
Thanks! (Fixes #884) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
2CA3
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
my Python is sysadmin-like so this PR might got the solution totally wrong. The reason I'm raising is I just hit this missing feature today and thought I'd give it a try to implement it for #884.