8000 Add support for tags in AWS::KMS::Key. by qassim · Pull Request #900 · cloudtools/troposphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for tags in AWS::KMS::Key. #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2017
Merged

Add support for tags in AWS::KMS::Key. #900

merged 1 commit into from
Nov 19, 2017

Conversation

qassim
Copy link
Contributor
@qassim qassim commented Nov 10, 2017 •
edited
Loading

AWS::KMS::Key doesn't currently support the Tags property. This change add this functionality.

Fixes issue: #889

@qassim qassim mentioned this pull request Nov 10, 2017
Closed
cigan1
cigan1 suggested changes Nov 16, 2017
View reviewed changes
Copy link
Contributor
@cigan1 cigan1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would it be better to set

'Tags': ((Tags, list), False),

Using the built in Tags class defined in init.py

@markpeek markpeek merged commit cfa41cf into cloudtools:master Nov 19, 2017
@markpeek
Copy link
Member

Thanks!

@markpeek
Copy link
Member
markpeek commen 81C2 ted Nov 19, 2017

@cigan1 I also added your suggested change in a subsequent commit. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cigan1 cigan1 cigan1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qassim @markpeek @cigan1
0