8000 remove elasticloadbalancingv2 LoadBalancer Validation by johnctitus · Pull Request #934 · cloudtools/troposphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove elasticloadbalancingv2 LoadBalancer Validation #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2017
Merged

remove elasticloadbalancingv2 LoadBalancer Validation #934

merged 1 commit into from
Dec 4, 2017

Conversation

johnctitus
Copy link
Contributor
@johnctitus johnctitus commented Dec 1, 2017 •
edited
Loading

This change removes the validation step from the LoadBalancer class to allow for conditionally setting one of these properties, while setting the other to AWS_NO_VALUE

Fixes #933

@johnctitus johnctitus changed the title Allow setting Subnets and SubnetMappings properties on ELBv2 LoadBala… remove elasticloadbalancingv2 LoadBalancer Validation Dec 1, 2017
@markpeek markpeek merged commit 2e683e4 into cloudtools:master Dec 4, 2017
@johnctitus
Copy link
Contributor Author

PR now change as follows:

elasticloadbalancingv2 LoadBalancer validation now checks if all mutually exclusive conditions are instances of the If class, and if so returns. Then proceeds to verifying only a single property is configured.

@markpeek
Copy link
Member
markpeek commented Dec 4, 2017

Thanks for the fix and reworking the PR.

@johnctitus johnctitus deleted the jct-nlb-validation branch December 4, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnctitus @markpeek
0