Add support for HealthCheckGracePeriodSeconds to ECS::Service #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobologic
reviewed
Jan 24, 2018
| @@ -89,6 +89,7 @@ class Service(AWSObject): | |||
| 'Cluster': (basestring, False), | |||
| 'DeploymentConfiguration': (DeploymentConfiguration, False), | |||
| 'DesiredCount': (positive_integer, False), | |||
| 'HealthCheckGracePeriodSeconds': (integer, False), | |||
There was a problem hiding this comment.
Should the validator here be positive_integer?
https://github.com/cloudtools/troposphere/blob/master/troposphere/validators.py#L27
This was referenced Jan 24, 2018
|
Actually, I'm going to go ahead and accept #966 since it should do what we want here. Thanks @acmcelwee ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Jan 23, the
ECS::Serviceresource has support for the newHealthCheckGracePeriodSecondsconfig.Docs