8000 Fix SES by mansdahlstrom1 · Pull Request #1047 · cloudtools/troposphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix SES #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2018
Merged

Fix SES #1047

merged 4 commits into from
May 17, 2018

Conversation

mansdahlstrom1
Copy link
Contributor
@mansdahlstrom1 mansdahlstrom1 commented May 17, 2018 •
edited
Loading

Fixes the following problem:

Class Template exists twice in this file, this will overwrite the first Template class. Can you please rename Template to EmailTemplate

Inspecting Ses Module...

def print_classes():
    for name, obj in inspect.getmembers(ses):
        if inspect.isclass(obj):
            print(obj)

print_classes()

<class 'troposphere.AWSObject'>
<class 'troposphere.AWSProperty'>
<class 'troposphere.ses.Action'>
<class 'troposphere.ses.AddHeaderAction'>
<class 'troposphere.ses.BounceAction'>
<class 'troposphere.ses.CloudWatchDestination'>
<class 'troposphere.ses.ConfigurationSet'>
<class 'troposphere.ses.ConfigurationSetEventDestination'>
<class 'troposphere.ses.DimensionConfiguration'>
<class 'troposphere.ses.EventDestination'>
<class 'troposphere.ses.Filter'>
<class 'troposphere.ses.IpFilter'>
<class 'troposphere.ses.KinesisFirehoseDestination'>
<class 'troposphere.ses.LambdaAction'>
<class 'troposphere.ses.ReceiptFilter'>
<class 'troposphere.ses.ReceiptRule'>
<class 'troposphere.ses.ReceiptRuleSet'>
<class 'troposphere.ses.Rule'>
<class 'troposphere.ses.S3Action'>
<class 'troposphere.ses.SNSAction'>
<class 'troposphere.ses.StopAction'>
<class 'troposphere.ses.Template'>
<class 'troposphere.ses.WorkmailAction'>
{
    "Resources": {},
    "Transform": "AWS::Serverless-2016-10-31"
}

And when running the same script on only the Template class...

def print_classes():
    for name, obj in inspect.getmembers(ses.Template):
        if inspect.isclass(obj):
            print(obj)

print_classes()

<type 'type'>
{
    "Resources": {},
    "Transform": "AWS::Serverless-2016-10-31"
}

@markpeek markpeek merged commit 47db869 into cloudtools:master May 17, 2018
@markpeek
Copy link
Member

Thanks! Note: likely I'll need to change the gen.py script to add this as an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansdahlstrom1 @markpeek
0