8000 Allow multiple NoValue properties in mutually_exclusive by phobologic · Pull Request #1050 · cloudtools/troposphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Allow multiple NoValue properties in mutually_exclusive #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2018
Merged

Allow multiple NoValue properties in mutually_exclusive #1050

merged 2 commits into from
May 23, 2018

Conversation

phobologic
Copy link
Member

mutually_exclusive ignores the value of properties, only looking at
whether or not they are defined. This causes a bug where you cannot
have two mutually exclusive properties, even if the value of those
properties is AWS::NoValue, which is allowed by cloudformation.

@phobologic
Allow multiple NoValue properties in mutually_exclusive
13df59d 
mutually_exclusive ignores the value of properties, only looking at
whether or not they are defined. This causes a bug where you cannot
have two mutually exclusive properties, even if the value of those
properties is AWS::NoValue, which is allowed by cloudformation.
@phobologic
Copy link
Member Author

Not sure what is going on with the tests - when I add from . import NoValue to troposphere/validators.py it causes random tests to break.

@phobologic phobologic requested a review from markpeek May 23, 2018 18:32
markpeek
markpeek approved these changes May 23, 2018
View reviewed changes
Copy link
Member
@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markpeek markpeek merged commit 01af6f5 into master May 23, 2018
@phobologic phobologic deleted the fix_novalue_mutually_exclusive branch May 23, 2018 18:43
@phobologic phobologic mentioned this pull request May 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpeek markpeek markpeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phobologic @markpeek
0