8000 Constants: ElastiCache + port numbers by philtay · Pull Request #132 · cloudtools/troposphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Constants: ElastiCache + port numbers #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 9, 2014
Merged

Constants: ElastiCache + port numbers #132

merged 6 commits into from
Oct 9, 2014

Conversation

philtay
Copy link
Contributor
@philtay philtay commented Sep 29, 2014

No description provided.

@markpeek
Copy link
Member

The ElastiCache change I agree with but I'm not sure I want to get into maintaining the (never ending) ports list. Let me think about it.

@philtay
Copy link
Contributor Author
philtay commented Sep 29, 2014

I think we could mimic the AWS console in this case. For instance, when you manually create a security group there is a select with a predefined set of very common ports (SSH, HTTP, HTTPS, etc.). My idea is to include only the very standard ports of the services that AWS provides. It's not a long list. We have: HTTP, HTTPS, SMTP, SSH, NTP, PostgreSQL, MySQL, Oracle, SQL server, Redis and Memcached. Maybe I'm forgetting something right now, but it won't be an unmaintainable mess :)

@philtay
Copy link
Contributor Author
philtay commented Sep 29, 2014

In the meantime I have implemented this:

https://aws.amazon.com/releasenotes/AWS-CloudFormation/2852434549047545

@phobologic
Copy link
Member

Looks like you missed SNS, but that shouldn't stop us from going ahead. Someone will add the SNS stuff when/if they need it :) Thanks philtay!

phobologic added a commit that referenced this pull request Oct 9, 2014
Constants: ElastiCache + port numbers
@phobologic phobologic merged commit f8ef3b6 into cloudtools:master Oct 9, 2014
@philtay
Copy link
Contributor Author
philtay commented Oct 12, 2014

There is nothing to add for SNS, they only removed some update restrictions. No new resources or properties.
Please don't forget to tag the new release (0.6.2) here: https://github.com/cloudtools/troposphere/releases

@phobologic
Copy link
Member

Oh, awesome - and thanks for the reminder, the release is up.

Hons pushed a commit to Hons/troposphere that referenced this pull request Dec 23, 2014
Constants: ElastiCache + port numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0