8000 Update the instance types in constants. by clokep · Pull Request #1353 · cloudtools/troposphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update the instance types in constants. #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2019
Merged

Update the instance types in constants. #1353

merged 2 commits into from
Mar 22, 2019

Conversation

clokep
Copy link
Contributor
@clokep clokep commented Mar 22, 2019

I was using a couple instance types that weren't included, so went through and added a bunch. You can see https://aws.amazon.com/ec2/instance-types/ for reference.

The u-xtb1.metal ones I wasn't really sure how to format, so I turned the - into a _, I also debated just removing the -.

Note that there were some duplicates in here, which I removed. I checked for more with:

sort troposphere/constants.py | uniq -c | sort

markpeek
markpeek requested changes Mar 22, 2019
View reviewed changes
Copy link
Member
@markpeek markpeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except one additional removal.

@markpeek markpeek merged commit a5d52fe into cloudtools:master Mar 22, 2019
@markpeek
Copy link
Member

Thanks!

@clokep clokep deleted the more-instance-types branch March 22, 2019 13:39
@clokep
Copy link
Contributor Author
clokep commented Mar 22, 2019

Thanks for the quick merge!

davemasino pushed a commit to davemasino/troposphere that referenced this pull request Oct 17, 2019
@clokep
Update the instance types in constants. (cloudtools#1353)
cfaf5d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpeek markpeek markpeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @markpeek
0