Add support for Rules #1446
Merged
Add support for Rules #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules are a feature of AWS Service Catalogue [1] but is undocumented for pure CloudFormation. However, it does work in vanilla CloudFormation as well [2]. This adds minimal support for Rules in templates. It provides a bare dict, and exports it to JSON/YAML. [1]: https://docs.aws.amazon.com/servicecatalog/latest/adminguide/reference-template_constraint_rules.html [2]: https://www.cloudar.be/awsblog/undocumented-feature-using-template-constraint-rules-in-cloudformation/
Merged
|
@nielslaukens since this was based on your original PR, can you review and give your +1? |
|
I would add a check for duplicate names, like it's done for I would also add a check on the maximum number of rules. I've searched for a documented maximum number of rules, but couldn't find one in the documentation. If I find the time, I'll try to figure out the current actual limit and configure that. Or put in a TODO for later... I've pulled in your changes, and added both of the above in my branch (#1412) |
|
Merged via the updated #1412. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules are a feature of AWS Service Catalogue 1 but is undocumented for pure CloudFormation. However, it does work in vanilla CloudFormation as well 2.
This adds minimal support for Rules in templates with a
Template.add_rule()function.A future improvement could bring a
Ruleclass to validate the contents of the rule itself.Originally contributed by @nielslaukens at #1412