Travis CI: Add flake8 which is a superset of pycodestyle and pyflakes 8000 #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[__flake8__](http://flake8.pycqa.org/) runs all the tests that pycodestyle and pyflakes do but also adds the Fxxx errors.
michael-k
reviewed
Sep 18, 2019
| - pycodestyle --show-source --show-pep8 . | ||
| - pyflakes . | ||
| - flake8 . --show-source |
There was a problem hiding this comment.
The invocations of pycodestyle and pyflakes can be removed, right?
|
I've been hesitant about accepting this PR since there are times when I've needed to "pin" a version of pycodestyle due to new rules or other breakage (5548d43). Is there a similar way to map pycodestyle versions to flake8 versions in the case of needing a rollback? |
|
|
|
Thank you for the PR. I'll be pushing a change to Makefile to run flake8 via "make test" to ensure consistency. |
markpeek
added a commit
that referenced
this pull request
Sep 19, 2019
|
I like make lint for things like flake8 and then make test for things like pytest, unittests, doctests, etc. |
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this pull request
Oct 17, 2019
davemasino
pushed a commit
to davemasino/troposphere
that referenced
this pull request
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 runs all the tests that pycodestyle and pyflakes do but also adds the Fxxx errors.
basestring was removed in Python 3.