8000 AWS::OpenSearchService::Domain.EngineVersion by jerry153fish · Pull Request #1960 · cloudtools/troposphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AWS::OpenSearchService::Domain.EngineVersion #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2021
Merged

AWS::OpenSearchService::Domain.EngineVersion #1960

merged 5 commits into from
Oct 15, 2021

Conversation

jerry153fish
Copy link
Contributor
@jerry153fish jerry153fish commented Oct 7, 2021 •
edited
Loading

@jerry153fish jerry153fish changed the title Feature/add opensearch AWS::Elasticsearch::Domain Oct 7, 2021
jerry153fish
jerry153fish commented Oct 7, 2021
View reviewed changes
@jerry153fish jerry153fish changed the title AWS::Elasticsearch::Domain AWS::OpenSearchService::Domain Oct 7, 2021
@markpeek
Copy link
Member
markpeek commented Oct 9, 2021

Thanks for making this change but I think I'm going to split this out into a separate file. I doubt AWS will make further improvements to Elasticsearch and OpenSearchService is their replacement. Might was well get this in its own namespace sooner than later.

@jerry153fish
Copy link
Contributor Author
jerry153fish commented Oct 10, 2021 •
edited
Loading

Got it. Do you want me to separate it? Or do you already have implemented the codes?

@markpeek
Copy link
Member

I added the base functionality with 8e6e4b6. Please feel free to add the additional validation and test from your PR. Thanks.

@jerry153fish jerry153fish changed the title AWS::OpenSearchService::Domain AWS::OpenSearchService::Domain.EngineVersion Oct 11, 2021
@markpeek markpeek merged commit f04a68e into cloudtools:main Oct 15, 2021
@jerry153fish jerry153fish deleted the feature/add-opensearch branch October 18, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerry153fish @markpeek
0