8000 Migrate to official php image · Issue #13 · clue/docker-adminer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate to official php image #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHu 8000 b”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mikehaertl opened this issue Sep 18, 2015 · 5 comments
Open

Migrate to official php image #13

mikehaertl opened this issue Sep 18, 2015 · 5 comments

Comments

@mikehaertl
Copy link

I see that instead of an official PHP base image this project uses a custom setup with nginx + php-fpm which requires supervisord to manage both services. So this is not in line with the recommended docker paradigm of one process per container.

It also seems to slow down the shutdown of this image. In a setup with 5 containers, it's always adminer that I have to wait for.

So would you consider a migration to the official apache based PHP image? It would make the Dockerfile simpler and take the burden of installing PHP from you. You still can tweak the PHP config though, if you want to.
@mikehaertl
Copy link
Author

@clue Any opinion on this?

@mathroc
Copy link
mathroc commented Apr 9, 2016

There is now an official image based on alpine (eg php:7.0-fpm-alpine), so it could solve #16 at the same time

@mikehaertl mikehaertl mentioned this issue Apr 9, 2016
Open
@clue
Copy link
Owner
clue commented Apr 10, 2016

There is now an official image based on alpine (eg php:7.0-fpm-alpine), so it could solve #16 at the same time

Sounds good to me! 👍

Does anybody feel like filing a PR?

@mikehaertl
Copy link
Author

@clue Good to hear! I think, this image can be simplified a lot. E.g. we should not need any supervisor at all. Using the official apache based PHP image it's only a matter of downloading the adminer source. That should also greatly improve startup/shutdown times.

mathroc added a commit to mathroc/docker-adminer that referenced this issue Apr 10, 2016
@mathroc
use official php alpine image
2e70b21 
closes clue#16 & clue#13
@mathroc mathroc mentioned this issue Apr 10, 2016
Closed
6 tasks
mathroc added a commit to mathroc/docker-adminer that referenced this issue Apr 10, 2016
@mathroc
use official php alpine image
85e50c4 
closes clue#16 & clue#13 & clue#17
mathroc added a commit to mathroc/docker-adminer that referenced this issue Apr 10, 2016
@mathroc
use official php alpine image
7a5b4af 
closes clue#16 & clue#13 & clue#17
@clue
Copy link
Owner
clue commented Apr 11, 2016

this image can be simplified a lot.

That's good to hear and I'm not opposed to getting any optimization in here at all :) This image has initially been created way before official PHP images were a thing. Now let's address these outstanding PRs :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use official php alpine image mathroc/docker-adminer
3 participants
@mathroc @mikehaertl @clue
0