Upgrade soon to be deprecated runners to newer versions #596
Conversation
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: macos-12 | ||
| runs-on: macos-14 |
There was a problem hiding this comment.
I updated the macOS runners a while ago after pushing changes and noticing the macOS builds were failing (see cmangos/mangos-tbc@9de293e and the merges this week to the other cores), so macOS builds should be fine again for now.
There's certainly something to say for going to macos-14 and arm64 builds, but also for using a somewhat older system (with typically older toolchain). The first tests that "newest" stuff can build the core, the second that it also still works with "older" stuff. I think we tend to go with older because newer is tested more by devs/users.
I'm going to guess the boost and MySQL changes are related to the move to arm64 macOS b 8000 uilds?
There was a problem hiding this comment.
Answer to this would be preferable before merging. Otherwise no comments from me @Niam5
There was a problem hiding this comment.
I commented below but it seems GH didn't send it out. The reason I set it to 14 is 13 is the last Intel runner as detailed here https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources so the choice is to either change now and fixup the runner for the direction GH is headed or just kick the can down the road and when 13 goes away do it then. Figured it was easier to fix it now and follow the direction the runners are going then just postponing it
There was a problem hiding this comment.
What? No it's not, just use macos-14-large or macos-15-large, those are intel..?
Seems like the info in your link is outdated. This is from the images repo directly:
https://github.com/actions/runner-images
https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md <- that's not arm.
src/realmd/CMakeLists.txt
Outdated
| @@ -77,7 +77,7 @@ if(UNIX) | |||
| endif() | |||
|
|
|||
| if(APPLE) | |||
| set(EXECUTABLE_LINK_FLAGS "-framework Carbon ${EXECUTABLE_LINK_FLAGS}") | |||
| set(EXECUTABLE_LINK_FLAGS "-Wl,-no_fixup_chains -framework Carbon ${EXECUTABLE_LINK_FLAGS}") | |||
There was a problem hiding this comment.
I actually fixed that problem a while ago (see cmangos/mangos-tbc@111e48d and the merge of that to other cores this week), so we don't need to sweep that issue under the carpet any more 😉
|
The issue with not moving to macOS arm now is it just pushes the issue down
the road a bit. GH doesn't have an x64 mac runner after macOS 13 so we can
do it now or later. Figured I would fix it now while I fixed the other
deprecated runners.
The mysql and boost versions are due to the way brew installs packages on
arm macs. It uses a different location for everything and not specifying
the versions causes it to grab mysql 9 and boost 1.87, since 1.87 isn't in
yet and the mysql 9 package was having issues i forced it to use known good
and supported versions.
…On Thu, Feb 20, 2025, 1:18 PM evil-at-wow ***@***.***> wrote:
***@***.**** commented on this pull request.
Using ubuntu-latest for the Discord stuff seems fine. Especially because
this PR shows this part gets forgotten anyway, unlike the actual builds.
------------------------------
In .github/workflows/macos.yml
<#596 (comment)>
:
>
permissions:
contents: read
jobs:
build:
- runs-on: macos-12
+ runs-on: macos-14
I updated the macOS runners a while ago after pushing changes and noticing
the macOS builds were failing (see ***@***.***
<cmangos/mangos-tbc@9de293e>
and the merges this week to the other cores), so macOS builds should be
fine again for now.
There's certainly something to say for going to macos-14 and arm64 builds,
but also for using a somewhat older system (with typically older
toolchain). The first tests that "newest" stuff can build the core, the
second that it also still works with "older" stuff. I think we tend to go
with older because newer is tested more by devs/users.
I'm going to guess the boost and MySQL changes are related to the move to
arm64 macOS builds?
------------------------------
In src/realmd/CMakeLists.txt
<#596 (comment)>
:
> @@ -77,7 +77,7 @@ if(UNIX)
endif()
if(APPLE)
- set(EXECUTABLE_LINK_FLAGS "-framework Carbon ${EXECUTABLE_LINK_FLAGS}")
+ set(EXECUTABLE_LINK_FLAGS "-Wl,-no_fixup_chains -framework Carbon ${EXECUTABLE_LINK_FLAGS}")
I actually fixed that problem a while ago (see ***@***.***
<cmangos/mangos-tbc@111e48d>
and the merge of that to other cores this week), so we don't need to sweep
that issue under the carpet any more 😉
—
Reply to this email directly, view it on GitHub
<#596 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD6KBLIZ4Z4VR7HDZS7EN32QZBD3AVCNFSM6AAAAABW6XUYPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZRGE3TAMBZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Because large runners are not free. Only standard runners are included for
no costs. And there are no standard Mac runners on MacOS 14+. See here
https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
…On Sat, May 17, 2025, 2:27 PM Thorbjørn H.H. Sindrup < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/macos.yml
<#596 (comment)>
:
>
permissions:
contents: read
jobs:
build:
- runs-on: macos-12
+ runs-on: macos-14
What? No it's not, just use macos-14-large or macos-15-large, those are
intel..?
Seems like the info in your link is outdated. This is from the images repo
directly:
https://github.com/actions/runner-images
Screenshot.2025-05-17.at.23.21.09.png (view on web)
<https://github.com/user-attachments/assets/9be6a3df-1f74-4320-99ef-85716719e50f>
https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md
<- that's not arm.
—
Reply to this email directly, view it on GitHub
<#596 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD6KBNLF3K6XXUEITALMQD266STNAVCNFSM6AAAAABW6XUYPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNBYGQYDGMRQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
wow really? locking mac intel, which is already legacy, behind a paywall is insane. I never tried the large ones, weird how it's not better documented at the actual repo, not a single mention of paid vs free runners. tsk. |
🍰 Pullrequest
Ubuntu 20.04 runners will soon be shut down by GH. Some of the Discord notifiers were still using this version. Also since there is only 1 remaining x64 Apple runner, upgraded the Apple CI test to be compatible with Apple Silicon.
Proof
(https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/)
Issues
How2Test
Todo / Checklist