Prevent client crash when vendor wants to send too many items #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerwife
added a commit
that referenced
this pull request
May 8, 2022
Closes #537 Hardcoded limitation in client
killerwife
added a commit
to cmangos/mangos-classic
that referenced
this pull request
May 21, 2022
Closes cmangos/mangos-tbc#537 Hardcoded limitation in client
killerwife
added a commit
to cmangos/mangos-wotlk
that referenced
this pull request
May 21, 2022
Closes cmangos/mangos-tbc#537 Hardcoded limitation in client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR ensures that vendors can never send more than 150 items to the client. Sending more than 150 items to the client seems to cause out-of-bounds reads, crashing it entirely.