8000 Makes the crew manifest function for non-USCM factions by BonniePandora · Pull Request #1018 · cmss13-devs/cmss13-pve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Makes the crew manifest function for non-USCM factions #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Makes the crew manifest function for non-USCM factions #1018

wants to merge 3 commits into from

Conversation

BonniePandora
Copy link
Contributor
@BonniePandora BonniePandora comm 8000 ented Jun 10, 2025

About the pull request

As the title says, this gets the crew manifest working for non-USCM factions (UPP & PMC as of writing this), with functionality for it to work with new factions in the future.
A few unused buttons have been removed from the main menu screen, "join as xeno", "view hive leaders" and "join as predator/join the hunt"
Due to some issues I had with roles spawning on the wrong faction (USCM rifleman when trying to spawn as UPP rifleman in this instance), I had to rename the affected role. The UPP Rifleman is now known as an Infantryman instead, short for their full title of Naval Infantryman.

Explain why it's good for the game

Tidier join screen = gooder. Less misleading buttons
The ability to see the crew manifest for UPP & PMC rounds was annoying at times, both as a yet-to-observe individual & as a player. This should rememdy it.

Testing Photographs and Procedure

Compiles without issue, tested on local and works as expected

image
image
image

Changelog

🆑
fix: Crew Manifest works for non-USCM factions
ui: Removes a few unused buttons on the main menu
/:cl:

@cm13-github
Copy link
Contributor
cm13-github commented Jun 12, 2025 •
edited
Loading

Test merge deployment history:

Test Merge Deployed @ 06/12/2025 15:23:27 +00:00:
Server Instance

PVECM: Green

Merged By

Joooks

Revision

Origin: 620f2c5
Pull Request: 1f66ba4
Server: bbb9c2c162bb1a4b30ee4e0d1bca40bfd3209a5e

Test Merge Updated @ 06/12/2025 15:28:03 +00:00:
Server Instance

PVECM: Green

Merged By

Joooks

Revision

Origin: 620f2c5
Pull Request: 1f66ba4
Server: 149cbbe585e67a8a3330413896be8ba47c3c89f4

Test Merge Updated @ 06/13/2025 10:22:39 +00:00:
Server Instance

PVECM: Green

Merged By

StinkethStonketh

Revision

Origin: 27c41e2
Pull Request: 1f66ba4
Server: 72214e6c154afd3b45c58799e7fe525c4b5337b3

Test Merge Removed @ 06/13/2025 10:53:22 +00:00:
Server Instance

PVECM: Green

Test Merge Deployed @ 06/22/2025 13:14:48 +00:00:
Server Instance

PVECM: Blue

Merged By

lordloko

Revision

Origin: abd3b29
Pull Request: 4d8e476
Server: a3674fd7bbb3b30d5a0ea63f61c65eace93ae180

Test Merge Updated @ 06/22/2025 17:29:30 +00:00:
Server Instance

PVECM: Blue

Merged By

lordloko

Revision

Origin: 6a08f8b
Pull Request: 4d8e476
Server: 2b9363531bf8eb2781f583a221ff17b7a67edaf0

Test Merge Deployed @ 06/22/2025 19:01:21 +00:00:
Server Instance

PVECM: Red

Merged By

twizzums

Revision

Origin: 4b4cd05
Pull Request: 4d8e476
Server: 7fa6e438fd14510fa5a791634d020f85fd5262a3

Test Merge Updated @ 06/22/2025 19:05:02 +00:00:
Server Instance

PVECM: Red

Merged By

twizzums

Revision

Origin: 4b4cd05
Pull Request: 4d8e476
Server: 2b47fff9121db9bde3b5d0b9343fdc9453beaf5a

Test Merge Updated @ 06/23/2025 00:04:08 +00:00:
Server Instance

PVECM: Blue

Merged By

shorttemperedleprech

Revision

Origin: 4b4cd05
Pull Request: 4d8e476
Server: fc6de74be1d2c63d4cb42cf2a18e4bd6ac58cde2

Test Merge Updated @ 06/23/2025 20:15:19 +00:00:
Server Instance

PVECM: Blue

Merged By

lordloko

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 34f464420b23588a0b4c95f5e289ec0714c04f74

Test Merge Removed @ 06/24/2025 01:01:47 +00:00:
Server Instance

PVECM: Red

Test Merge Updated @ 06/24/2025 03:09:21 +00:00:
Server Instance

PVECM: Blue

Merged By

Some Random Username

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 525879f239091cb01431f50aca4dac85cb523c01

Test Merge Deployed @ 06/26/2025 12:51:37 +00:00:
Server Instance

PVECM: Red

Merged By

Emilitia Ennehrt

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 45bd191794b554035aa56d788e4fced6bf5f99ff

Test Merge Updated @ 06/26/2025 16:07:31 +00:00:
Server Instance

PVECM: Red

Merged By

goshflipheck

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: f2636f5bb0f3665325570d968d497e75e6d22b5d

Test Merge Updated @ 06/26/2025 19:47:35 +00:00:
Server Instance

PVECM: Red

Merged By

StinkethStonketh

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 8142f01614b8e7e1285444c534d2b3057e875799

Test Merge Updated @ 06/27/2025 00:25:52 +00:00:
Server Instance

PVECM: Blue

Merged By

shorttemperedleprech

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: efe799fd3e1405b385bab9be00727a5ee6370d83

Test Merge Updated @ 06/27/2025 11:09:12 +00:00:
Server Instance

PVECM: Red

Merged By

MessageCypher

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: c547ba844b39a84636593a5e2a9c449bdc12a148

Test Merge Updated @ 06/27/2025 18:58:51 +00:00:
Server Instance

PVECM: Blue

Merged By

lordloko

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: cef95ff19f0be8b6fd3f5497eaa67ee3b87bb74e

Test Merge Updated @ 06/27/2025 19:05:18 +00:00:
Server Instance

PVECM: Blue

Merged By

lordloko

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 28639277b36e8e016ff397084ac410147e60bd96

Test Merge Updated @ 06/27/2025 21:15:27 +00:00:
Server Instance

PVECM: Blue

Merged By

lordloko

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 3f9cf097f1acf00f8dd68cab314bf12adb0bb65a

Test Merge Deployed @ 06/27/2025 23:38:20 +00:00:
Server Instance

PVECM: Green

Merged By

StinkethStonketh

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: ad53c4773869f6b9d239bd84c228ef1a271b9d75

Test Merge Removed @ 06/28/2025 01:05:43 +00:00:
Server Instance

PVECM: Blue

Test Merge Updated @ 06/28/2025 09:29:10 +00:00:
Server Instance

PVECM: Green

Merged By

Joooks

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 380525254dd3818b8b36725599f333a448c6265a

Test Merge Updated @ 06/28/2025 09:38:22 +00:00:
Server Instance

PVECM: Green

Merged By

Joooks

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: d7ae21d39d3cbe7cbc497c8b969cdd6c8b936afe

Test Merge Updated @ 06/28/2025 09:49:39 +00:00:
Server Instance

PVECM: Green

Merged By

Joooks

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: f572760f460ae107206dfb460c3643007b6c90ad

Test Merge Updated @ 06/28/2025 14:43:24 +00:00:
Server Instance

PVECM: Green

Merged By

Warfan

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 2d03e8fb83358652737c399f4126e240e0e3cc60

Test Merge Deployed @ 06/28/2025 15:28:41 +00:00:
Server Instance

PVECM: Blue

Merged By

lordloko

Revision

Origin: e6c14d5
Pull Request: 4d8e476
Server: 1d739b9ac84c68199afc3ce3bc4b0d37261644c5

Test Merge Removed @ 06/28/2025 19:02:21 +00:00:
Server Instance

PVECM: Green

Test Merge Deployed @ 06/29/2025 10:24:42 +00:00:
Server Instance

PVECM: Green

Merged By

Joooks

Revision

Origin: 5d6f309
Pull Request: 4d8e476
Server: e0b7ab26292b5d7d9fbe779aceb087da43bb2b17

Test Merge Removed @ 06/29/2025 13:26:25 +00:00:
Server Instance

PVECM: Green

Test Merge Updated @ 06/29/2025 22:48:46 +00:00:
Server Instance

PVECM: Red

Merged By

alanparkermasters

Revision

Origin: 5d6f309
Pull Request: 4d8e476
Server: 519462624e6dd86ed33d8ddb7571b8b490ce7e82

Test Merge Updated @ 06/30/2025 07:18:16 +00:00:
Server Instance

PVECM: Blue

Merged By

Emilitia Ennehrt

Revision

Origin: 5d6f309
Pull Request: 4d8e476
Server: c91f3bbc3a8543b8ef5c9f1c2c9bc11fb206f14c

Test Merge Removed @ 06/30/2025 19:41:47 +00:00:
Server Instance

PVECM: Red

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndroBetel AndroBetel AndroBetel approved these changes

Assignees
No one assigned
Labels
fix UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BonniePandora @cm13-github @AndroBetel
0