10000 Added hadolint + new cnes-scan version by Topin2001 · Pull Request #92 · cnescatlab/docker-cat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added hadolint + new cnes-scan version #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2024
Merged

Added hadolint + new cnes-scan version #92

merged 1 commit into from
Aug 5, 2024

Conversation

Topin2001
Copy link
Contributor

Proposed changes

Added hadolint to support the lastest version of cnes-scan (2.1.0) along the corresponding tests

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • Codacy validates the quality of the modifications
  • GitHub Actions CI workflow passes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@Topin2001 Topin2001 added this to the 3.4.0 milestone Aug 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@Topin2001 Topin2001 requested a review from louisjdmartin August 2, 2024 14:24
@louisjdmartin
Copy link
Member

Faut voir pour marquer les 2 security hotspot comme safe vu que ce sont des fichiers tests qui sont impactés (visiblement je peux pas le faire moi même)

@Topin2001 Topin2001 merged commit 0290820 into develop Aug 5, 2024
2 of 3 checks passed
@Topin2001 Topin2001 deleted the feature/add-hadolint-with-cnes-scan-update branch August 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisjdmartin louisjdmartin louisjdmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Topin2001 @louisjdmartin
0