8000 fix: vclusters argo cluster secret labels by squidboylan · Pull Request #56 · cnoe-io/stacks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: vclusters argo cluster secret labels #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix: vclusters argo cluster secret labels #56

merged 1 commit into from
Mar 6, 2025

Conversation

squidboylan
Copy link
Contributor

Kubernetes labels do not support more than 1 / in their name from what I understand:

Labels are key/value pairs. Valid label keys have two segments: an optional prefix and name, separated by a slash (/). The name segment is required and must be 63 characters or less, beginning and ending with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between. The prefix is optional. If specified, the prefix must be a DNS subdomain: a series of DNS labels separated by dots (.), not longer than 253 characters in total, followed by a slash (/).

https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/

without this change I get the following error when runnign the add-vclusters.sh script:

* metadata.labels: Invalid value: "cnoe.io/vclusterMultiEnv/clusterName": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')
* metadata.labels: Invalid value: "cnoe.io/vclusterMultiEnv/clusterClass": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName',  or 'my.name',  or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName')

@squidboylan
fix: vclusters argo cluster secret labels
a1b6b2f 
Signed-off-by: Caleb Boylan <calebboylan@gmail.com>
greghaynes
greghaynes approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor
@greghaynes greghaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@punkwalker punkwalker merged commit 6a2ec77 into cnoe-io:main Mar 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greghaynes greghaynes greghaynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squidboylan @greghaynes @punkwalker
0