8000 Map `vpiPackedArray` objects to LogicArrayObject by ktbarrett · Pull Request #4746 · cocotb/cocotb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Map vpiPackedArray objects to LogicArrayObject #4746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Map vpiPackedArray objects to LogicArrayObject #4746

wants to merge 2 commits into from

Conversation

ktbarrett
Copy link
Member
@ktbarrett ktbarrett commented Jun 11, 2025 •
edited
Loading

Xcelium returns packed arrays as vpiPackedArrayVar and vpiPackedArrayNet. These should really be mapped to LogicArrayObject which is for packed logic array types.

@imphil
Copy link
Member
imphil commented Jun 11, 2025

Can you have a look why our tests didn't catch that? E.g. https://github.com/cocotb/cocotb/blob/master/tests/test_cases/test_struct/test_struct.py

@ktbarrett
Copy link
Member Author

@imphil Xcelium returns vpiPackedArrayNet when the type is a packed array of packed structs. We aren't testing that anywhere. That should be in test_multi_dimensional_array, but the packed struct aspect of that test was never completed AFAICT. Probably because Icarus didn't support it.

@ktbarrett ktbarrett force-pushed the ktbarrett-patch-1 branch from 9558bca to d0ebb7a Compare June 13, 2025 04:57
@ktbarrett
Copy link
Member Author

Added tests for this. See the original failure.

Riviera is now failling though. It takes a complete dump trying to access packed structs.

@ktbarrett ktbarrett force-pushed the ktbarrett-patch-1 branch from 3d8a246 to 1bb296c Compare June 15, 2025 19:24
@ktbarrett ktbarrett requested a review from a team June 17, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmarqu cmarqu cmarqu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktbarrett @imphil @cmarqu
0