8000 fix: remove unsupported type casting in integer vector handling by lemorage · Pull Request #619 · cocoindex-io/cocoindex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: remove unsupported type casting in integer vector handling #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

fix: remove unsupported type casting in integer vector handling #619

merged 1 commit into from
Jun 12, 2025

Conversation

lemorage
Copy link
Contributor

In #595 and #586, we added support for numeric types in numpy array annotations. np.uint types and np.int32 were included even though in cocoindex data types we could only handle Int64, Float64 and Float32. We achieved this by type casting.

This PR attempts to remove the casting, and only supports np.int64, np.float64 and np.float32 for consistency.

Relevant proposal: #586 (comment)

badmonster0
badmonster0 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member
@badmonster0 badmonster0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@badmonster0 badmonster0 merged commit 0586b8e into cocoindex-io:main Jun 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badmonster0 badmonster0 badmonster0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
< 394F input type="hidden" data-csrf="true" name="authenticity_token" value="L0i7HSnqmLZ0fmfDW5NXMqdza5im/CeoatLNuxTW6UHaE0AmvQ0AxNI0CQ+GqpeVA1xBpJ73YYroiVhv0GqbFQ==" />
Development

Successfully merging this pull request may close these issues.
2 participants
@lemorage @badmonster0
0