8000 should raise an exception if failed to initialize shaders by jareguo · Pull Request #3329 · cocos/cocos-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

should raise an exception if failed to initialize shaders #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2018
Merged

should raise an exception if failed to initialize shaders #3329

merged 1 commit into from
Sep 28, 2018

Conversation

jareguo
Copy link
Contributor
@jareguo jareguo commented Sep 27, 2018

避免用户漏掉关键的报错信息，导致沟通效率低下
image

这里的 log 其实是 error，但是用户看不出来的话反馈问题的时候就会跳过。

@jareguo jareguo requested a review from pandamicro September 27, 2018 07:54
@pandamicro pandamicro merged commit 50c7efc into cocos:v1.10-release Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandamicro pandamicro pandamicro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jareguo @pandamicro
0