8000 set webAudio volume immediately by PPpro · Pull Request #4767 · cocos/cocos-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

set webAudio volume immediately #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

set webAudio volume immediately #4767

merged 1 commit into from
Jul 3, 2019

Conversation

PPpro
Copy link
Contributor
@PPpro PPpro commented Jul 1, 2019 •
edited
Loading

Re: https://github.com/cocos-creator/2d-tasks/issues/1582

changeLog:

  • 修复 webAudio 设置音量，没有立即生效的问题

相关论坛反馈：https://forum.cocos.com/t/creator-h5-demo/79989

@PPpro
Copy link
Contributor Author
PPpro commented Jul 1, 2019

麻烦 @VisualSJ 有空看看这个修复有没有问题

@PPpro
Copy link
Contributor Author
PPpro commented Jul 2, 2019 •
edited
Loading

关联之前的修复：781efe4

可能需要 @VisualSJ 解释下，为什么之前需要 0.01 的延时

@PPpro
Copy link
Contributor Author
PPpro commented Jul 3, 2019

之前设置 0.01 是为了解决一些浏览器上的兼容性问题，现在不需要了

@knoxHuang
Copy link
Contributor
8000

那之前需要兼容的浏览器上是否有问题呢？

@PPpro
Copy link
Contributor Author
PPpro commented Jul 3, 2019

我在几个主流的 UC chrome qq 微信浏览器上测试，没什么问题

@jareguo jareguo merged commit 979d137 into cocos:v2.1.2 Jul 3, 2019
@jareguo
Copy link
Contributor
jareguo commented Jul 3, 2019

蛋疼，以后大家都注意，千万别在代码里出现这种 magic number，要嘛就写注释说明

@PPpro PPpro deleted the 2.1_audio2 branch August 20, 2020 02:23
@PPpro PPpro mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knoxHuang knoxHuang knoxHuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PPpro @knoxHuang @jareguo
0