8000 fix webaduio.setTargetTime on crosswalk by PPpro · Pull Request #5281 · cocos/cocos-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix webaduio.setTargetTime on crosswalk #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

fix webaduio.setTargetTime on crosswalk #5281

merged 1 commit into from
Aug 30, 2019

Conversation

PPpro
Copy link
Contributor
@PPpro PPpro commented Aug 29, 2019

changeLog:

  • 修复 crosswalk web 引擎上 setTargetAtTime 的报错

手机百度浏览器比较奇葩，try catch 捕获不到异常，所以目前已知的浏览器类型判断就先保留着吧

@PPpro PPpro force-pushed the 2.1.3_audio branch 3 times, most recently from daf7fab to 099dd9b Compare August 29, 2019 12:13
@jareguo jareguo requested review from knoxHuang and VisualSJ August 29, 2019 12:30
@PPpro
Copy link
Contributor Author
PPpro commented Aug 30, 2019

相关 issue: https://github.com/cocos-creator/2d-tasks/issues/1058

@jareguo jareguo merged commit c7e4c17 into cocos:v2.1.3 Aug 30, 2019
@PPpro PPpro deleted the 2.1.3_audio branch September 5, 2019 17:34
@PPpro PPpro mentioned this pull request Aug 20, 2020
Merged
Sign up for free to jo 67BA in this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VisualSJ VisualSJ VisualSJ approved these changes

@knoxHuang knoxHuang knoxHuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PPpro @VisualSJ @knoxHuang @jareguo
0