optimize json merging #6716
Merged
optimize json merging #6716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cocos2d/core/asset-manager/pipeline.js
# Conflicts: # cocos2d/core/load-pipeline/pack-downloader.js # cocos2d/core/load-pipeline/unpackers.js # cocos2d/core/load-pipeline/uuid-loader.js # cocos2d/core/platform/deserialize.js # test/qunit/unit-es5/test-pack-downloader.js # test/qunit/unit-es5/test-pack-unpack.js
# Conflicts: # cocos2d/core/asset-manager/deserialize.js # cocos2d/core/asset-manager/pack-manager.js # cocos2d/core/platform/deserialize-compiled.ts # cocos2d/core/platform/deserialize.js # gulp/util/utils.js # test/qunit/unit/test-serialize-compiled.js
jareguo
commented
May 19, 2020
| * @typescript | ||
| * isSceneObj(json: any): boolean | ||
| */ | ||
| isSceneObj: function (json) { |
|
|
||
| if (Array.isArray(json)) { | ||
|
|
||
| json = unpackJSONs(json, cc._MissingScript.safeFindClass); |
There was a problem hiding this comment.
@holycanvas 在这里插入了 json 拆分的逻辑，大 json 下载后就会通过这个 API 拆分成小 json
| lookupClasses(data, options); | ||
| cacheMasks(data); | ||
| if (!preprocessed) { | ||
| lookupClasses(data, false, options.classFinder); |
There was a problem hiding this comment.
如果 json 未拆分过（单独的资源），则走完整的类型查找流程
| throw new Error(cc.debug.getError(5304, data[File.Version])); | ||
| } | ||
| lookupClasses(data, true, classFinder); | ||
| cacheMasks(data); |
There was a problem hiding this comment.
拆分 json 的逻辑很简单，只是提前做了类的查找
SantyWang
reviewed
Jun 11, 2020
cocos2d/core/3d/particle/curve.ts
Outdated
| export class AnimationCurve { | ||
| @property({ | ||
| default: [], |
There was a problem hiding this comment.
这个好像不能改来着，之前改了，3d粒子就没动画了
There was a problem hiding this comment.
我确认了一下目前的数据还是对的。粒子能播放。可能因为是 ES6 的类。
gulp/util/inline-prop.js
Outdated
| } | ||
|
|
||
| exports.inlineEnum = function (filename) { | ||
| if (filename.endsWith('.js') || filename.endsWith('.ts')) { |
|
预加载的解析依赖的逻辑可能得调整下，不过问题不大 |
# Conflicts: # cocos2d/core/asset-manager/deserialize.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
减小合并后的 json 体积，json 越大效果越明显， Asset Bundle 整个合并的话能减小 5% - 20%。
因为只对合并做优化，不合并的话整个项目而言包体只是略微减小。
结合前一个 PR，目前大场景或者合并后的大 json 体积最多能优化到原先的 25%。
对整个项目来说所有 json 的体积差不多能优化 30%。