Fix ios device bad display effect #4265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- https://github.com/cocos-creator/3d-tasks/issues/11159
|
测试过相关的issue https://github.com/cocos-creator/3d-tasks/issues/5814 没有问题。 |
minggo
reviewed
Feb 24, 2022
templates/ios/ViewController.mm
Outdated
| CAMetalLayer *layer = (CAMetalLayer *)self.view.layer; | ||
| CGSize tsize = CGSizeMake(static_cast<int>(size.width * pixelRatio), | ||
| static_cast<int>(size.height * pixelRatio)); | ||
| //self.view.contentScaleFactor = pixelRatio; |
minggo
reviewed
Feb 24, 2022
templates/ios/ViewController.mm
Outdated
| cc::EventDispatcher::dispatchOrientationChangeEvent((int) orientation); | ||
| _lastOrientation = orientation; | ||
| } | ||
| cc::EventDispatcher::dispatchOrientationChangeEvent((int) orientation); |
There was a problem hiding this comment.
也要 static_cast 吧
|
restart ci |
|
Update 2022.03.08: This Pull request didn't provide enough information to developers. Without the fix, when the developer builds an app with several orientations, the display effect for the start orientation is good, but once the orientation is changed, the screen is stretched and touchpoints are lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.