storage: check for additional split work after a split #10232
Conversation
7cdc79b to
c622a42
Compare
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
Reviewed 2 of 2 files at r1. pkg/sql/table_split_test.go, line 43 at r1 (raw file):
should be Fatal pkg/sql/table_split_test.go, line 47 at r1 (raw file):
should check these errors. pkg/sql/table_split_test.go, line 50 at r1 (raw file):
optional: const Comments from Reviewable |
After splitting a range, further split work might be required if the zone config changed or a table was created concurrently or if the range was much larger than the target size. Before this change, TestSplitAtTableBoundary had a wide variance in how long it would take. Sometimes it would completely in less than a second while other times it would take 10-20 seconds. With this change it reliably completes in less than a second. Fixes cockroachdb#10160
|
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. pkg/sql/table_split_test.go, line 43 at r1 (raw file):
|
c622a42 to
7750433
Compare
After splitting a range, further split work might be required if the
zone config changed or a table was created concurrently or if the range
was much larger than the target size.
Before this change, TestSplitAtTableBoundary had a wide variance in how
long it would take. Sometimes it would completely in less than a second
while other times it would take 10-20 seconds. With this change it
reliably completes in less than a second.
Fixes #10160
This change is