Makefile: add a gss go build tag #35223
Conversation
This allows us to only build gss support if the Makefile determines it's ok, instead of relying on Go's build tags as well. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @knz and @nvanbenschoten)
|
bors r+ |
Build failed |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
Trying to get the build back to green for now. Release note: none.
|
I want a green build so skipping the docker test (looks like it is connecting to the wrong port) and adding some stubs to the test to get the uncovered code at least referenced so Unused isn't unhappy. Hopefully this should look greener. |
|
LGTM |
|
You and me both: I don't know how it passed before given that error -- it suggests the env var in the dockerfile doesn't work?. But either way, it is failing now and I just want the build to be green, so skipping until we can debug it later. |
|
bors r+ |
35223: Makefile: add a gss go build tag r=tbg a=mjibson This allows us to only build gss support if the Makefile determines it's ok, instead of relying on Go's build tags as well. Release note: None Co-authored-by: Matt Jibson <matt.jibson@gmail.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Build succeeded |
|
Publish bleeding edge is green, so this seems to have worked.
|
|
The test probably stopped passing after adding the build tag. Maybe mkrelease needs to also be told about the gss tag? Everything is silly. |
This allows us to only build gss support if the Makefile determines it's
ok, instead of relying on Go's build tags as well.
Release note: None