release-2.1: teamcity-trigger: plumb TC_BUILD_BRANCH env var into builder #30133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0bc52b added a dependency on the TC_BUILD_BRANCH env var to the teamcity-trigger binary, but the wrapping shell script was not propagating the variable into the builder's env. Release note: None
|
This change is |
|
LGTM
…On Wed, Sep 12, 2018 at 2:25 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/30133>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#30133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBcTyU1orhjYpxer7AZ7tQAeLREWodks5uaVGxgaJpZM4Wl7NP>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #30128.
/cc @cockroachdb/release
c0bc52b added a dependency on the TC_BUILD_BRANCH env var to the
teamcity-trigger binary, but the wrapping shell script was not
propagating the variable into the builder's env.
Release note: None