release-19.1: util/log: ensure stderr is only redirected to th… #40942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The code that would redirect stderr would kick in on the first log
event for any secondary logger, not the main one, because the
predicate to activate the redirection was only using the boolean
variable on the main logger (which is always true).
This patch fixes the issue by properly using the per-logger boolean to
make this determination.
Release note (bug fix): Detailed crash reports ("panic messages")
could previously be reported in the wrong file, if SQL audit reporting
or statement logging had been activated. This has been corrected and
crash reports will now properly always appear in the main log file.
1a552cd to
e912f8c
Compare
bdarnell
approved these changes
Sep 20, 2019
|
TFYR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #40941.
/cc @cockroachdb/release
Fixes #40940
Release justification: bug fix for a bug that severely affects our ability to troubleshoot issues