kv/concurrency: bump goroutine stall delay #57355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#57273. This commit bumps the goroutine stall delay in the TestConcurrencyManagerBasic framework from 1ms to 5ms. In cockroachdb#57273, we saw a flake due to a goroutine being classified as stalled when it was actually waiting for a multi-goroutine chain of events to fire (request exits lockTable, signals lockTable wait-queue, which is noticed by watchForNotifications, which cancels the pushers context). This chain of events plus the 1ms wait in the framework led to a flake under stress roughly every 16k iterations. With this delay bumped to 3ms, I have never reproduced the flake after over 2M iterations. This PR bumps the delay all the way up to 5ms to be extra sure. This increases the runtime of all subtests combined from 1.6s to 3.9s.
|
This change is |
irfansharif
approved these changes
Dec 2, 2020
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57273.
This commit bumps the goroutine stall delay in the TestConcurrencyManagerBasic
framework from 1ms to 5ms. In #57273, we saw a flake due to a goroutine being
classified as stalled when it was actually waiting for a multi-goroutine
chain of events to fire (request exits lockTable, signals lockTable wait-queue,
which is noticed by watchForNotifications, which cancels the pushers context).
This chain of events plus the 1ms wait in the framework led to a flake under
stress roughly every 16k iterations. With this delay bumped to 3ms, I have never
reproduced the flake after over 2M iterations. This PR bumps the delay all the
way up to 5ms to be extra sure. This increases the runtime of all subtests
combined from 1.6s to 3.9s.