cli: extract the SQL connection code to a new package clisqlclient (2/)
#67457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
f564f34 to
496f036
Compare
otan
reviewed
Jul 13, 2021
| @@ -0,0 +1,71 @@ | |||
| // Copyright 2021 The Cockroach Authors. | |||
There was a problem hiding this comment.
nit: should this be called clierror.go, to match the package name?
There was a problem hiding this comment.
There are more files coming to it in later PRs, including an error.go because there will be an Error type. That's the "native" one here.
496f036 to
e2fd278
Compare
Thanks for the feedback. I have split that change into a separate commit as requested. RFAL. |
otan
approved these changes
Jul 13, 2021
pkg/cli/flags_util.go
Outdated
| @@ -323,6 +323,7 @@ const ( | |||
| tableDisplayRecords | |||
| tableDisplaySQL | |||
| tableDisplayHTML | |||
| tableDisplayRawHTML | |||
There was a problem hiding this comment.
can you add a comment explaining the difference between rawhtml and html?
Previously, the cluster setting markdown table was generated with a `gen` sub-command that was trying to be too clever with the HTML generator. This was making it complicated to move the table formatting code to a separate package. This commit simplifies the code by introducing a new output format 'rawhtml' (raw, as in, it does not escape HTML special characters inside table cells). Since this format is only used internally to auto-generate this table, the help texts leave it undocumented. Release note: None
This commit leaves the code in an intermediate stage, where the unit tests pass but maybe the linter is unhappy. This will be cleaned up in the next commit. Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
e2fd278 to
ae9938c
Compare
|
TFYR! bors r=otan |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
67458: cli: some cleanups to the new package `clisqlclient` (3/) r=otan a=knz First 6 commits are from #67457 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 3 commits belong to this PR.. This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages. 67459: cli: new sub-package `clisqlexec` for the execution/formatting code (4/) r=otan a=knz First 9 commits are from #67458 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 6 commits belong to this PR. This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages. 67460: cli: move the demo cluster to new sub-package `democluster` (5/) r=otan a=knz First 15 commits are from #67459 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 5 commits belong to this PR. This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages. 67461: cli: SQL shell cleanups and better encapsulation (6/) r=otan a=knz First 20 commits are from #67460 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 4 commits belong to this PR. This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages. 67474: cli: new sub-package `clisqlcfg` to ease the creation of a standalone SQL shell (8/) r=otan a=knz First 28 commits are from #67462 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 2 commits belong to this PR. This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages. Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
craig bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
67458: cli: some cleanups to the new package `clisqlclient` (3/) r=otan a=knz First 6 commits are from #67457 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 3 commits belong to this PR.. This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages. 67459: cli: new sub-package `clisqlexec` for the execution/formatting code (4/) r=otan a=knz First 9 commits are from #67458 and prior. Please ignore those (they will disappear once the prefix PR is merged) Only the last 6 commits belong to this PR. This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages. Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a family of PRs that aim to encapsulate CLI functionality into finer grained packages.