build: fix beta tag build #8886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the beta-* tag builder built static binaries after the push-docker-deploy step, which prevents push-docker-deploy from running the acceptance tests. It made up for this by running the acceptance tests manually. Now push-docker-deploy will run the acceptance tests instead.
|
LGTM. |
|
Correct, it does run the acceptance tests. |
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the beta-* tag builder built static binaries after the
push-docker-deploy step, which prevents push-docker-deploy from running
the acceptance tests. It made up for this by running the acceptance
tests manually. Now push-docker-deploy will run the acceptance tests
instead.
This change is