8000 release-22.1: sql: add bulkio.column_backfill.update_chunk_size_threshold_bytes by postamar · Pull Request #83816 · cockroachdb/cockroach · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

release-22.1: sql: add bulkio.column_backfill.update_chunk_size_threshold_bytes #83816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

release-22.1: sql: add bulkio.column_backfill.update_chunk_size_threshold_bytes #83816

merged 1 commit into from
Jul 5, 2022

Conversation

postamar
Copy link
@postamar postamar commented Jul 5, 2022 •
edited
Loading

Backport 1/1 commits from #83544.

/cc @cockroachdb/release

Release justification: backwards-compatible fix for bug which can stall schema changes

This commit adds this cluster setting, defaulting to 10 MiB, which
complements the bulkio.column_backfill.batch_size setting to limit the
size of the column backfiller update batches.

Fixes #83199.

Release note (bug fix): fixes bug where ADD/DROP COLUMN with the legacy
schema changer could fail on tables with large rows due to exceeding the
raft command max size.

sql: add bulkio.column_backfill.update_chunk_size_threshold_bytes
fb86e4d 
This commit adds this cluster setting, defaulting to 10 MiB, which
complements the bulkio.column_backfill.batch_size setting to limit the
size of the column backfiller update batches.

Fixes cockroachdb#83199.

Release note (bug fix): fixes bug where ADD/DROP COLUMN with the legacy
schema changer could fail on tables with large rows due to exceeding the
raft command max size.
@blathers-crl
Copy link
blathers-crl bot commented Jul 5, 2022 •
edited by postamar
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar requested review from ajwerner and devadvocado July 5, 2022 16:01
ajwerner
ajwerner approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor
@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @devadvocado)

@postamar postamar marked this pull request as ready for review July 5, 2022 17:54
@postamar postamar requested a review from a team July 5, 2022 17:54
@postamar postamar merged commit 2ca7454 into cockroachdb:release-22.1 Jul 5, 2022
@postamar postamar deleted the backport22.1-83544 branch July 5, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

@devadvocado devadvocado Awaiting requested review from devadvocado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@postamar @cockroach-teamcity @ajwerner
0