8000 Remove Leader leases from v24.3 docs by rmloveland · Pull Request #19252 · cockroachdb/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove Leader leases from v24.3 docs #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

Remove Leader leases from v24.3 docs #19252

merged 2 commits into from
Jan 7, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-12000

They will be in Preview in v25.1

Remove Leader leases from v24.3 docs
5b7bdd7 
Fixes DOC-12000

They will be in Preview in v25.1
@github-actions GitHub Actions
Copy link

Files changed:

@netlify Netlify
Copy link
netlify bot commented Dec 19, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit e174045
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/677d45b9fcdeee000841e95d

@netlify Netlify
Copy link
netlify bot commented Dec 19, 2024 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit e174045
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/677d45b9257c5a00080fb160

@netlify Netlify
Copy link
netlify bot commented Dec 19, 2024 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit e174045
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/677d45b9cbc7970008fb86cf
😎 Deploy Preview https://deploy-preview-19252--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmloveland
Copy link
Contributor Author

@taroface not gonna ping you for review on this one since it's "just" a deletion

but FYI this is removing leader leases from preview in v24.3 since we're gonna actually have in preview in v25.1

it's already appearing properly in the v25.1 docs since it was added in #18989 (which you reviewed) and then got copied over during the "create v25.1 docs" process

@rmloveland rmloveland merged commit 39ab95a into main Jan 7, 2025
6 checks passed
@rmloveland rmloveland deleted the 20241219-DOC-12000-remove-leader-leases-docs branch January 7, 2025 15:27
@taroface
Copy link
Contributor
taroface commented Jan 7, 2025

Thx for this context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arulajmani arulajmani arulajmani approved these changes

@nhamlani101 nhamlani101 Awaiting requested review from nhamlani101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmloveland @taroface @arulajmani
0