8000 create `drpc.ClientConn` wrapping a `drpc.Conn` by cthumuluru-crdb · Pull Request #9 · cockroachdb/drpc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

create drpc.ClientConn wrapping a drpc.Conn #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

create drpc.ClientConn wrapping a drpc.Conn #9

merged 1 commit into from
Jun 18, 2025

Conversation

cthumuluru-crdb
Copy link
@cthumuluru-crdb cthumuluru-crdb commented Jun 18, 2025 •
edited
Loading

Create a client connection from a drpc.Conn. drpc.Conn can be a concrete connection or a pooled connection to the target node.

@cthumuluru-crdb cthumuluru-crdb changed the title create a clientconn wrapping drpc.Conn Create a clientconn wrapping drpc.Conn Jun 18, 2025
@cthumuluru-crdb cthumuluru-crdb changed the title Create a clientconn wrapping drpc.Conn create a ClientConn wrapping drpc.Conn Jun 18, 2025
@cthumuluru-crdb @shaikzakiriitm
drpcclient: create a clientconn wrapping drpc.Conn
ab155d9 
Here, we are updating constructor of clientConn to take in a
`drpc.Conn` type object instead of a supplier of `drpc.Conn`.
This simplifies the usage/construction of clientConn, and moves
the responsibility of invoking a supplier/dialer to the caller of
constructor. This way, closing of drpcpool would be a clear duty
of the caller of this constructor.
@shaikzakiriitm shaikzakiriitm marked this pull request as ready for review June 18, 2025 08:36
@cthumuluru-crdb cthumuluru-crdb changed the title create a ClientConn wrapping drpc.Conn create drpc.ClientConn wrapping a drpc.Conn Jun 18, 2025
@cthumuluru-crdb cthumuluru-crdb merged commit e79a954 into cockroachdb:main Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaikzakiriitm shaikzakiriitm shaikzakiriitm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthumuluru-crdb @shaikzakiriitm
0