8000 Deleted upstream dependency; bump github.com/cockroachdb/errors · Issue #3659 · cockroachdb/pebble · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Deleted upstream dependency; bump github.com/cockroachdb/errors #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karalabe opened this issue Jun 14, 2024 · 7 comments · Fixed by #3660
Closed

Deleted upstream dependency; bump github.com/cockroachdb/errors #3659

karalabe opened this issue Jun 14, 2024 · 7 comments · Fixed by #3660
Assignees
@nicktrav
Labels
A-storage O-community T-storage

Comments

@karalabe
Copy link
karalabe commented Jun 14, 2024 •
edited
Loading

Hey there,

We've received a report that our builds are failing ethereum/go-ethereum#29984, and it seems it's a dependency issue originating from Pebble, which in turn originates from github.com/cockroachdb/errors v1.11.1 (fixed in cockroachdb/errors#137).

It appears that an upstream repo (sentry-go -> iris)... just... deleted it's published git version tag. /facepalm

Any chance of bumping the github.com/cockroachdb/errors package in mainline pebble to the one that has the fixed dependency, and then tagging a v1.1.1 patch release do we could also pick up the fix?

Thanks
@karalabe
Copy link
Author

I'm assuming builds are still ok-ish for most systems because Go uses GOPROXY by default which caches the packages at Google, so those get served out of bounds and not pulled form GitHub, but I'd wager disabling the Go proxy will error.

nicktrav added a commit to nicktrav/pebble that referenced this issue Jun 14, 2024
@nicktrav
go: bump cockroachdb/errors to v1.11.3
6073025 
Closes cockroachdb#3659.
@nicktrav nicktrav mentioned this issue Jun 14, 2024
Merged
@nicktrav nicktrav self-assigned this Jun 14, 2024
@nicktrav nicktrav moved this from Incoming to In Progress (this milestone) in [Deprecated] Storage Jun 14, 2024
@nicktrav
Copy link
Contributor

Thanks for pointing this out, @karalabe. Fix is up in #3660.

nicktrav added a commit that referenced this issue Jun 14, 2024
@nicktrav
go: bump cockroachdb/errors to v1.11.3
646c6ba 
Closes #3659.
@github-project-automation github-project-automation bot moved this from In Progress (this milestone) to Done in [Deprecated] Storage Jun 14, 2024
nicktrav added a commit to nicktrav/pebble that referenced this issue Jun 14, 2024
@nicktrav
go: bump cockroachdb/errors to v1.11.3
bc53d0e 
Touches cockroachdb#3659.
@nicktrav nicktrav mentioned this issue Jun 14, 2024
Merged
nicktrav added a commit to nicktrav/pebble that referenced this issue Jun 14, 2024
@nicktrav
go: bump cockroachdb/errors to v1.11.3
404a7b0 
Touches cockroachdb#3659.
@nicktrav nicktrav mentioned this issue Jun 14, 2024
Merged
nicktrav added a commit to nicktrav/pebble that referenced this issue Jun 14, 2024
@nicktrav
go: bump cockroachdb/errors to v1.11.3
ee5c0d0 
Touches cockroachdb#3659.
nicktrav added a commit that referenced this issue Jun 14, 2024
@nicktrav
go: bump cockroachdb/errors to v1.11.3
6803ae8 
Touches #3659.
nicktrav added a commit that referenced this issue Jun 14, 2024
@nicktrav
go: bump cockroachdb/errors to v1.11.3
19829bc 
Touches #3659.
@karalabe
Copy link
Author

Thank you!

@nicktrav
Copy link
Contributor

We ran into some issues up in Cockroach and needed to revert. We wont yank the existing tag, so you should still be fine with that version, but we'll want to figure this out by the time we next tag.

Going to re-open to track figuring this out.

@nicktrav nicktrav reopened this Jun 18, 2024
@github-project-automation github-project-automation bot moved this from Done to Incoming in [Deprecated] Storage Jun 18, 2024
@nicktrav nicktrav changed the title Deleted upstream dependency Deleted upstream dependency; bump github.com/cockroachdb/errors Jun 18, 2024
@RaduBerinde
Copy link
Member

I created a pebble-release-1.1 branch at the v1.1.1 tag onto which we can cherry-pick commits if/when we need to make a new 1.1.2 release.

I don't think we want to update these deps in CRDB 23.2/24.1 just for the sake of it.

@nicktrav
Copy link
Contributor

I don't think we want to update these deps in CRDB 23.2/24.1 just for the sake of it.

Sounds good. Feel free to close if there's nothing left to do here.

@RaduBerinde
Copy link
Member

Cool, I'll close - we'll make sure the newer deps are kept if more 1.1.x versions are tagged.

@github-project-automation github-project-automation bot moved this from Incoming to Done in [Deprecated] Storage Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicktrav nicktrav

Labels
A-storage O-community T-storage
Projects
No open projects
[Deprecated] Storage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go: bump cockroachdb/errors to v1.11.3 nicktrav/pebble
3 participants
@karalabe @nicktrav @RaduBerinde
< 160F ghcc-consent id="ghcc" class="position-fixed bottom-0 left-0" style="z-index: 999999" data-initial-cookie-consent-allowed="" data-cookie-consent-required="true">
0