8000 Items: Move ItemCache into dedicated submodule by SchoolGuy · Pull Request #3535 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Items: Move ItemCache into dedicated submodule #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2024
Merged

Items: Move ItemCache into dedicated submodule #3535

merged 1 commit into from
Jan 2, 2024

Conversation

SchoolGuy
Copy link
Member

Linked Items

This is a splitout of #3440

Description

This PR moves the item cache out of the item module. The tests are already separated and thus don't need splitting out.

Behaviour changes

Old: Nothing changes

New: Nothing changes

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Dec 31, 2023
@SchoolGuy SchoolGuy mentioned this pull request Dec 31, 2023
Open
@SchoolGuy SchoolGuy requested a review from a team December 31, 2023 13:05
@SchoolGuy SchoolGuy added the no changelog This doesn't need a changelog label Dec 31, 2023
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% ✅ 86.96%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (edd91aa) 15959 10616 66.52%
Head commit (326a438) 15963 (+4) 10619 (+3) 66.52% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3535) 23 20 86.96%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

ByteOtter
ByteOtter approved these changes Jan 2, 2024
View reviewed changes
Copy link
@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell 👍🏼

@SchoolGuy SchoolGuy merged commit e626a52 into main Jan 2, 2024
@SchoolGuy SchoolGuy deleted the feature/move-item-cache branch January 2, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteOtter ByteOtter ByteOtter approved these changes

Assignees
No one assigned
Labels
no changelog This doesn't need a changelog
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @ByteOtter
0