Remove built-in configuration management #3537
Conversation
95d15af to
57dbc5a
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
898d3c4 to
d1b7b1c
Compare
d1b7b1c to
0efffbc
Compare
|
I would very much like to ask that we ignore pyright on this PR since all non-CLI changes are related to tests. Those are indeed valid and important but much of it is not fixable (external library) or not a reasonable effort ( |
There was a problem hiding this comment.
Generally I like removing code we don't need/want anymore 👍
A project-wide search shows there are still a number of mgmtclass/package/file references that should be delete as well. I left comments for some of them on some files, there were a few more (e.g. in Makefile).
0efffbc to
bf8f29c
Compare
|
@agraul I believe I have addressed all your desired changes for now. My own search doesn't yield any more leftovers. As such I think another review round is appropriate. |
There was a problem hiding this comment.
I still see references to mgmtclasses (didn't search for the others):
Makefile:172: -rm /var/lib/cobbler/cobbler_collections/mgmtclasses/*
cobbler/services.py:364: :param what: May be "systems", "profiles", "distros", "images", "repos", "mgmtclasses", "packages",
cobbler/services.py:381: elif what == "mgmtclasses":
cobbler/services.py:382: listing = self.remote.get_mgmtclasses() # type: ignore
system-tests/tests/svc-list:13:# TODO add more systems, profiles and distros, images, repos, mgmtclasses, packages, files, menus
docs/user-guide/http-api.rst:412:``systems, profiles, distros, images, repos, mgmtclasses, packages, files, menus``
cobbler/settings/migrations/V3_0_0.py:323: "mgmtclasses.d",
The old migration shoud be fine, I don't know about the Makefile, user docs, and services.py
bf8f29c to
477d417
Compare
|
@agraul The |
Linked Items
Fixes #3536
Description
This PR removed the configuration management item types:
Package,FileandMgmtclass. Since the HTTP API endpoint/svc/op/puppetrequires these item types it was removed as well.Merging this PR means that the next version is going to be 4.0.0 and not 3.4.0, switching that will be done in another PR. This PR is big enough already.
This PR was created to simplify the work on #3440.
Behaviour changes
Old: Cobbler had basic configuration management that was able to provision simple things through Koan.
New: Code for the configuration management is removed.
Category
This is related to a:
Tests