8000 Move NetworkInterface class to dedicated module by SchoolGuy · Pull Request #3739 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move NetworkInterface class to dedicated module #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

Move NetworkInterface class to dedicated module #3739

merged 1 commit into from
Jul 9, 2024

Conversation

SchoolGuy
Copy link
Member
@SchoolGuy SchoolGuy commented Jul 2, 2024 •
edited
Loading

Linked Items

Split-out of #3440

Description

This PR is a preparation for issue #3439. It moves the NetworkInterface class into a dedicated module.

The changelog will be added once the final piece of the refactoring is successful.

Behaviour changes

Old: The NetworkInterface was embedded into the system module.

New: The NetworkInterface class has its own dedicated Python module

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Jul 2, 2024
@SchoolGuy SchoolGuy requested a review from a team July 2, 2024 13:32
@SchoolGuy SchoolGuy added no changelog This doesn't need a changelog and removed API tests labels Jul 2, 2024
@SchoolGuy SchoolGuy force-pushed the feature/move-network-interface-to-dedicated-module branch from baec474 to b4fe225 Compare July 2, 2024 13:43
@SchoolGuy SchoolGuy force-pushed the feature/move-network-interface-to-dedicated-module branch from b4fe225 to 68e054f Compare July 2, 2024 13:56
m-czernek
m-czernek approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor
@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, a simple refactor, leaving just a few non-blocking comments.

@SchoolGuy SchoolGuy force-pushed the feature/move-network-interface-to-dedicated-module branch from 0d02c0d to fcb8356 Compare July 8, 2024 13:31
@SchoolGuy @m-czernek
Move NetworkInterface class to dedicated module
ad71b5d 
Co-authored-by: Marek Czernek <marek.czernek@suse.com>
@SchoolGuy SchoolGuy force-pushed the feature/move-network-interface-to-dedicated-module branch from fcb8356 to ad71b5d Compare July 8, 2024 13:43
@SchoolGuy SchoolGuy merged commit aa08227 into main Jul 9, 2024
31 of 45 checks passed
@SchoolGuy SchoolGuy deleted the feature/move-network-interface-to-dedicated-module branch July 9, 2024 06:50
@SchoolGuy SchoolGuy mentioned this pull request Jul 9, 2024
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-czernek m-czernek m-czernek approved these changes

Assignees
No one assigned
Labels
API no changelog This doesn't need a changelog tests
Projects
Cobbler Server
Status: Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SchoolGuy @m-czernek
0