10000 Items: Introduce InheritableItem by SchoolGuy · Pull Request #3787 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Items: Introduce InheritableItem #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

SchoolGuy
Copy link
Member

Linked Items

Split-Out of #3440

Description

This is a new abstract item type that has all methods needed to query for parents and children.

Behaviour changes

None

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Jul 22, 2024
@SchoolGuy SchoolGuy mentioned this pull request Jul 22, 2024
12 tasks
@github-actions github-actions bot added the tests label Jul 22, 2024
@SchoolGuy SchoolGuy added no changelog This doesn't need a changelog and removed tests labels Jul 22, 2024
@SchoolGuy SchoolGuy requested a review from m-czernek July 22, 2024 13:17
@SchoolGuy SchoolGuy force-pushed the feature/introduce-inheritable-item branch from e3c6971 to 97111e2 Compare July 22, 2024 13:18
@github-actions github-actions bot added the tests label Jul 22, 2024
Copy link
codacy-production bot commented Jul 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 90.91% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f47b967) 15924 10638 66.80%
Head commit (26f313a) 15959 (+35) 10674 (+36) 66.88% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3787) 176 160 90.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor
@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks good to me, leaving a few suggestions that we might consider fixing as part of the refactor.

@SchoolGuy SchoolGuy force-pushed the feature/introduce-inheritable-item branch from 192e0cb to d938d90 Compare August 7, 2024 11:22
@SchoolGuy SchoolGuy requested a review from m-czernek August 7, 2024 11:22
@github-actions github-actions bot added the API label Aug 7, 2024
@SchoolGuy SchoolGuy force-pushed the feature/introduce-inheritable-item branch from d938d90 to 9bba9b7 Compare August 7, 2024 11:28
Copy link
Contributor
@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, leaving just very minor nits about docs

@SchoolGuy SchoolGuy force-pushed the feature/introduce-inheritable-item branch from 8e835d9 to e91d2e5 Compare August 7, 2024 12:48
SchoolGuy and others added 4 commits August 7, 2024 14:55
This is a new abstract item type that has all methods needed to query for
parents and children.

Co-authored-by: Marek Czernek <marek.czernek@suse.com>
@SchoolGuy SchoolGuy force-pushed the feature/introduce-inheritable-item branch from e91d2e5 to 26f313a Compare August 7, 2024 12:56
@SchoolGuy SchoolGuy merged commit 732c688 into main Aug 7, 2024
33 of 47 checks passed
@SchoolGuy SchoolGuy deleted the feature/introduce-inheritable-item branch August 7, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API no changelog This doesn't need a changelog tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
0