Issue 691 hangout participant count #719

railsstudent · 2017-11-18T07:53:26Z

Fixes #691.

Create a MongoDB collection app_stats with schema { hangout_id: string, participant_count: number }
A unique index should be created for hangout_id
// add unique index, db.app_stats.createIndex({ hangout_id, 1}, { unique: true });

Server publishes hangoutParticipants and allHangoutParticipants to return number of participants in a specific hangout room

In single study group.js, participant count is shown in a badge in 24/7 hangout tab
In hangout_frame.js, participant count is shown in a well below jitsu hangout. participant count is incremented when user loads jitsu and decremented when user leaves the page
In all study room.js and my study room.js, participant count of 24/7 hangout is listed for each study room; adjacent to laptop icon

0.9.5 Release

Release 0.9.6

…ddies#693) (codebuddies#694)

…o staging

…to staging

Issue-691. show number of hangout participants in all study group and my study group pages issue-691. Only decrement participant count when the logged in user joins the hangout room Issue-691 Decrement participant count when value is positive

railsstudent · 2017-11-18T07:58:32Z

…m/railsstudent/codebuddies into railsstudent-issue-691-hangout-participant-count

railsstudent · 2017-11-19T14:41:20Z

@distalx Changes made to get rid of the session variable

distalx

Thanks for the PR! Here are some suggestions I hope you'll find helpful.

distalx · 2017-11-22T18:35:53Z

server/hangouts/methods.js

@@ -404,3 +404,36 @@ Meteor.methods({

  }
 });
+
+Meteor.methods({


Please Move methods related to AppStats collection under a /server/app_stats/methods.js directory.
joinParticipant and leaveParticipant

distalx · 2017-11-22T18:37:41Z

server/hangouts/publications.js

@@ -82,3 +82,22 @@ Meteor.publish( 'hangoutSearch', function(searchTerm) {

    return Hangouts.search(searchTerm);
 });
+
+Meteor.publish('hangoutParticipants', function(room) {


hangoutParticipants and allHangoutParticipants These publications should be also placed under /server/app_stats/publications.js directory.

distalx · 2017-11-22T18:39:58Z

server/hangouts/publications.js

+});
+
+Meteor.publish('allHangoutParticipants', function(hangoutRoomIds) {
+  if (hangoutRoomIds == null || typeof hangoutRoomIds === 'undefined' ||


Please make use of check here.
i.e. check(hangoutRoomIds, Match.Maybe([String]))

railsstudent · 2017-11-24T14:04:56Z

@distalx Changes made

railsstudent · 2017-11-26T06:55:41Z

@distalx Please kindly review this PR when you have time. Thanks.

distalx · 2017-12-03T15:21:11Z

Great work @railsstudent! 👏 . Love seeing it all come together! LGTM! 👍

I have made few changes.

storing a participant object inside participants list instead of just a count to avoid duplicates.
adding a user to participants list when user join the hangout by using a join here link.

_ Although there is a one scenario which is really hard to get around._

When a person join the hangout by using a join here link it will open the Jitsi in a new tab. We are not able to remove that person from the list of participants when that person close down the Jitsi tab. We are only able remove that person from the list of participants when that person either close down the CB app or log off from it.

So there are two possibilities, when user won’t get the accurate participants count.

when a person close down the Jitsi tab and don’t close down the CB app or log off from it.
when a person close down the CB app or log off from it and don’t close down the Jitsi tab.

Possible solutions !

remove the join here link.
it reduces the complexity of tracking user’s actions out side the CB app. we have added the join here link because sometimes Jitsi fails during loading process and ppl might have to refresh the page to start the load process again.
run a cron job.
as a last resort we could always implement a cron job which trigger at every couple of hours and reset/update the active participant count. it isn’t directly addresses the issue on hand but it reduces the possibility of stale data which is the by product of our current implementation.

cc @lpatmo , @sergeant-q.

…unt' into issue-691-hangout-participant-count

lpatmo · 2017-12-10T06:23:05Z

Thanks for the hard work here, @railsstudent and @distalx! 👏

When a person join the hangout by using a join here link it will open the Jitsi in a new tab. We are not able to remove that person from the list of participants when that person close down the Jitsi tab. We are only able remove that person from the list of participants when that person either close down the CB app or log off from it.

I'm not too worried about this scenario, actually. If they close the Jitsi tab but forget to close the CB app, they'll still technically be in the hangout, right? Of the two proposed solutions, I would lean towards the cron job instead of removing the "click here" link, since I think the user experience is more terrible if you can't get in to the hangout at all. Plus, the external link gives us easy access to the URL for the Jitsi room.

Shall I punt the cron job into a new issue -- and in the meantime, merge to staging?

lpatmo · 2017-12-10T06:39:54Z

One thought: in client/templates/study_groups/all_study_groups.html and in client/templates/study_groups/my_study_groups.html, do you think it might make sense to only show the laptop icon with the number count next to it if there is at least one person in the 24/7 room?

I.e.

+ {{# if numParticipants _id }}<small><i class="fa fa-laptop fa-fw"></i>{{ numParticipants _id }}</small>{{/if}}
- <small><i class="fa fa-laptop fa-fw"></i>{{ numParticipants _id }}</small>

That way we won't have a bunch of laptop icons with (0) next to it, and it'd be easier to tell which study group rooms have active people at first glance. Thoughts welcome!

railsstudent · 2017-12-12T14:08:56Z

@lpatmo Okay. I will work on it in the weekend.
I have slacked off since taking an interest in golang

lpatmo · 2017-12-15T07:52:52Z

@railsstudent If you feel like you've slacked off, then I've been... comatose? :P

The change is pretty straightforward -- it would be those two lines I pasted above for all_study_groups.html and my_study_groups.html, but before we make it let me know what you think of the idea! I'm not against showing it at all times either; am mostly worried that potentially having a lot of 0s will be off-putting.

railsstudent · 2017-12-15T08:05:16Z

@lpatmo I think it is a good idea to hide the laptop icon when no one is in 24/7 hangout.
Since the study group card is so small, it is prudent to convey only meaningful data.

lpatmo · 2017-12-15T08:17:29Z

Thanks!

railsstudent · 2017-12-17T01:56:45Z

@lpatmo Templates fixed. Please kindly review

lpatmo

Excellent! Thank you.

* Issue 691 hangout participant count (#719) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * Issue-691. Show number of participants in 24/7 hangout Issue-691. show number of hangout participants in all study group and my study group pages issue-691. Only decrement participant count when the logged in user joins the hangout room Issue-691 Decrement participant count when value is positive * Remove unique index comment * fix 'participants_count' of undefined console err * Get rid of session variable * Move server-side logic to new files * Enable seed data * minor improvements * Show laptop icon when people join 24/7 hangout * Fix account deletion. (#745) * fix typo * Schedule hangout default studygroup name (#743) * Default study group name when schedule a hangout in single study group duplicate hangout in single study group * Default study group name value is not displayed in dropdown input area unless trigger('change') is fired * Fixed error * Issue 667 create slack page (#744) * Create new Slack page * Add helpful links * Minor content edits! Note: I removed the slackin plugin in favor of a direct link because I noticed some positioning issues with the form that appears after a user clicks on the plugin; it's sometimes out of reach, and will make the user think that nothing happened. * Show study group name in disabled input box in modal (#748) * Refactoring 1 (#752) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * refactor (routes) remove subs from router level * refactor (hangout_logged_out) make use of new syntax * refactor (hangouts) - remove dead code, restructure single hangout view

* Issue 691 hangout participant count (#719) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * Issue-691. Show number of participants in 24/7 hangout Issue-691. show number of hangout participants in all study group and my study group pages issue-691. Only decrement participant count when the logged in user joins the hangout room Issue-691 Decrement participant count when value is positive * Remove unique index comment * fix 'participants_count' of undefined console err * Get rid of session variable * Move server-side logic to new files * Enable seed data * minor improvements * Show laptop icon when people join 24/7 hangout * Fix account deletion. (#745) * fix typo * Schedule hangout default studygroup name (#743) * Default study group name when schedule a hangout in single study group duplicate hangout in single study group * Default study group name value is not displayed in dropdown input area unless trigger('change') is fired * Fixed error * Issue 667 create slack page (#744) * Create new Slack page * Add helpful links * Minor content edits! Note: I removed the slackin plugin in favor of a direct link because I noticed some positioning issues with the form that appears after a user clicks on the plugin; it's sometimes out of reach, and will make the user think that nothing happened. * Show study group name in disabled input box in modal (#748) * Refactoring 1 (#752) * fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694) * refactor (routes) remove subs from router level * refactor (hangout_logged_out) make use of new syntax * refactor (hangouts) - remove dead code, restructure single hangout view * Add 'add to google calendar' button that opens up link with event details from hangout, including meet.jit.si location (#755) * Display fallback image if image url of contributor is broken (#756) * Issue 547 redesign of /hangouts page (#757) * redesigned header area * hangouts area now uses flexbox + big redesign of cards area * adjust column display on profile page * completed hangout cards do not need to be very tall; also, hide meta content on hover * add popover descriptions for silent/collaboration/teaching icon keys * grammar correction * update hangout-faq a bit more, and give it its own route * capitalization fixes * adjust hover behavior of btn-block * fix up hangout cards in study groups * update faq content

lpatmo and others added 7 commits October 15, 2017 02:14

Merge pull request codebuddies#664 from codebuddiesdotorg/staging

c815d9b

0.9.5 Release

Merge pull request codebuddies#689 from codebuddiesdotorg/staging

9e0ce10

Release 0.9.6

fix for bug 690: admins should be able to access 24/7 hangout (codebu…

d02daf8

…ddies#693) (codebuddies#694)

Merge branch 'master' of github.com:codebuddiesdotorg/codebuddies int…

f127b41

…o staging

Merge branch 'staging' of github.com:codebuddiesdotorg/codebuddies in…

6b375c0

…to staging

Remove unique index comment

f19f835

lpatmo added the [state] in-review the implementation that addresses this issue is up for review label Nov 18, 2017

railsstudent requested a review from distalx November 18, 2017 07:58

distalx and others added 5 commits November 19, 2017 00:22

Merge branch 'issue-691-hangout-participant-count' of git://github.co…

c4c591e

…m/railsstudent/codebuddies into railsstudent-issue-691-hangout-participant-count

fix 'participants_count' of undefined console err

14821c7

Merge remote-tracking branch 'upstream/staging' into staging

6ff72f2

Merge branch 'staging' into issue-691-hangout-participant-count

e52a2e4

Get rid of session variable

02f01bb

railsstudent added 3 commits November 20, 2017 04:47

Merge remote-tracking branch 'upstream/staging' into staging

b2e11f9

Merge remote-tracking branch 'upstream/staging' into staging

f6b6d27

Merge remote-tracking branch 'upstream/staging' into staging

24da525

distalx requested changes Nov 22, 2017

View reviewed changes

distalx mentioned this pull request Nov 22, 2017

See number of people in 24/7 Hangouts #691

Closed

railsstudent added 3 commits November 24, 2017 20:19

Merge remote-tracking branch 'upstream/staging' into staging

91e7c24

Merge branch 'staging' into issue-691-hangout-participant-count

03eeba4

Move server-side logic to new files

6f52d47

railsstudent added 4 commits November 26, 2017 14:41

Merge remote-tracking branch 'upstream/staging' into staging

d45ea41

Merge remote-tracking branch 'upstream/staging' into staging

9c5aeec

Merge branch 'staging' into issue-691-hangout-participant-count

c4dfcb5

Enable seed data

5809d32

minor improvements

ddbd1c5

distalx approved these changes Dec 3, 2017

View reviewed changes

Merge remote-tracking branch 'origin/issue-691-hangout-participant-co…

2c760ad

…unt' into issue-691-hangout-participant-count

Show laptop icon when people join 24/7 hangout

2a2b206

lpatmo approved these changes Dec 17, 2017

View reviewed changes

lpatmo merged commit b1b0b20 into codebuddies:staging Dec 17, 2017

lpatmo added [state] closed the issue is now closed, see comments for more information and removed [state] in-review the implementation that addresses this issue is up for review labels Dec 17, 2017

lpatmo mentioned this pull request Dec 23, 2017

IDEA: Let study group admins choose a channel to automate 24/7 participation notifications #751

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue 691 hangout participant count #719

Issue 691 hangout participant count #719

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Issue 691 hangout participant count #719

Issue 691 hangout participant count #719

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!