8000 Add twitter handle to learnings by vinmaster · Pull Request #997 · codebuddies/codebuddies · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add twitter handle to learnings #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2018
Merged

Add twitter handle to learnings #997

merged 1 commit into from
Oct 7, 2018

Conversation

vinmaster
Copy link
Contributor

Fixes #967

Here I pulled the userId from learning object and find the user by it. After getting the user, I make sure there is twitter social profile attached. If there is, then I use the twitter handle. If not, I keep the original functionality of the code that was here

lpatmo
lpatmo approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member
@lpatmo lpatmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vinmaster!

@lpatmo lpatmo merged commit 251c99c into codebuddies:staging Oct 7, 2018
@lpatmo lpatmo added [state] closed the issue is now closed, see comments for more information and removed Waiting For Review labels Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatmo lpatmo lpatmo approved these changes

Assignees
No one assigned
Labels
[state] closed the issue is now closed, see comments for more information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinmaster @lpatmo
0